[procrunner] avoid waiting for processes forever #65909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
spalger
added
the
release_note:skip
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 11, 2020
# Conflicts: # packages/kbn-pm/dist/index.js
This was referenced May 11, 2020
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 11, 2020
# Conflicts: # packages/kbn-pm/dist/index.js
spalger
pushed a commit
that referenced
this pull request
May 11, 2020
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
spalger
pushed a commit
that referenced
this pull request
May 13, 2020
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use the proc runner to wait for a process to log a specific line before considering it "started", it will wait until the process exits. Doing that has caused issues on CI where in some cases Kibana never is "ready", so we should apply a timeout that kills the process after some time (rather than relying on Jenkins to destroy the workers after 2 hours).
This adds a default
waitTimeoutforproc.run()calls that specify awaitexpressions of 15 minutes. This should give any usage enough time to get started, but can be extended by passing an alternatewaitTimeout, or settingwaitTimeout: false